1. sfParameterHolderValidation.class.php
  2. /**
 * Finds usage of array notation with a parameter holder.
 *
 * @package    symfony
 * @subpackage task
 * @author     Fabien Potencier 
 * @version    SVN: $Id: sfParameterHolderValidation.class.php 25411 2009-12-15 15:31:29Z fabien $
 */
  3. class sfParameterHolderValidation extends sfValidation
  4. {
  5.   public function getHeader()
  6.   {
  7.     return 'Checking usage of array notation with a parameter holder';
  8.   }
  10.   public function getExplanation()
  11.   {
  12.     return array(
  13.           '',
  14.           '  The files above use the array notation with a parameter holder,',
  15.           '  which is not supported anymore in symfony 1.4.',
  16.           '  For instance, you need to change this construct:',
  17.           '',
  18.           '    $foo = $request->getParameter(\'foo[bar]\')',
  19.           '',
  20.           '  to this one:',
  21.           '',
  22.           '    $params = $request->getParameter(\'foo\')',
  23.           '    $foo = $params[\'bar\'])',
  24.           '',
  25.     );
  26.   }
  28.   public function validate()
  29.   {
  30.     $found = array();
  31.     $files = sfFinder::type('file')->name('*.php')->prune('vendor')->in(array(
  32.       sfConfig::get('sf_apps_dir'),
  33.       sfConfig::get('sf_lib_dir'),
  34.       sfConfig::get('sf_test_dir'),
  35.       sfConfig::get('sf_plugins_dir'),
  36.     ));
  37.     foreach ($files as $file)
  38.     {
  39.       $content = sfToolkit::stripComments(file_get_contents($file));
  41.       if (preg_match('#\b(get|has|remove)(Request)*Parameter\(\s*[\'"][^\),]*?\[[^\),]#', $content))
  42.       {
  43.         $found[$file] = true;
  44.       }
  45.     }
  47.     return $found;
  48.   }
  49. }
Debug toolbar